Simple fix to prevent negative tauaer in RRTMG LW #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr0cloud
added
bugfix
|
Its technically zero-diff label because any negative tauaer would have caused a crash so not run at all! |
sdrabenh
approved these changes
Feb 3, 2022
sdrabenh
deleted the
feature/pnorris/#520-negative-tauaer-ocurring-in-RRTMG-LW
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RRTMG LW does not scatter and so it must extract the absorption aerosol optical depth. This should be taua_ext - taua_scat, which in the parlance of the un-normalized radiation variables in the RRTMG LW section is TAUA - SSAA.
Unfortunately this difference is sometimes a small negative value. This is not the fault of the Radiation GC, since it gets these two variables directly by callback to the aerosol system. It should really be fixed on the aerosol side, but as a simple mitigation for now, we make the fix max(TAUA - SSAA, 0.).