-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/jkolassa/gndtmp cn cleanup #536
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ription on inputs
gmao-jkolassa
added
0 diff
The changes in this pull request have verified to be zero-diff with the target branch.
cleanup
labels
Feb 10, 2022
…nd heat subroutines [gndtmp(), gndtp0()]
gmao-rreichle
approved these changes
Feb 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
preliminary 0-diff tests successful:
- AGCM (Biljana)
- GEOSldas (Rolf) [as expected, tests with aggressive build had roundoff differences]
gmao-rreichle
approved these changes
Feb 11, 2022
sdrabenh
approved these changes
Feb 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #530 and involves a cleanup of subroutines
gndtmp
andgdntmp_cn
.Subroutine
gndtmp
was modified to make several input arguments optional and make parts of the code dependent on the presence of these optional input arguments. As a resultgndtmp
can now be called instead ofgndtmp_cn
while still retaining all previous functionality. The now obsolete subroutinegndtmp_cn
was removed.Two points to note/discuss:
gndtmp
in order to avoid having to make all inputs keyword arguments. I have updated all calls togndtmp
accordingly. If the preference is that the input order remains the same, I can make the necessary changes, but it will mean that all input arguments have to be passed as keyword arguments.gndtmp(_cn)
and the temperature variable names that have been implemented as part of the peat PR. Depending on when each PR is expected to be merged, I can include the changes that were made in the peat PR here.I have tested this new branch in 3 one-month offline experiments using Catchment, Catchment-CN4.0 and Catchment-CN4.5. For all three experiments the model outputs after one month were zero-diff with respect to a simulation generated with 'develop'. I have not run any coupled simulations.