Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup of scaling albedo with fpar #589

Merged
merged 2 commits into from
May 23, 2022

Conversation

biljanaorescanin
Copy link
Contributor

Removing model/ experiment specific scaling with fpar. This option was by default set to zero, scaling was not used, this cleanup is zero diff. In boundary conditions package, option to create these parameters was commented out as well, so change is zero diff for boundary conditions as well.
@gmao-rreichle @gmao-jkolassa @rdkoster

@biljanaorescanin biljanaorescanin added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. cleanup labels May 16, 2022
@gmao-rreichle
Copy link
Contributor

Thanks, @biljanaorescanin, for putting this together. I don't have time to look at the changes in detail until later this week or next.
However, I'm wondering if it would not be better to split this PR into two. The plan for #576 was to have only changes in ./Raster. The make_bcs clean up (changes in ./Raster) from the present PR can be merged into #576 as set up in the present PR.
But if we also merge the changes in the model code from this branch into #576, then the scope of #576 broadens and #576 also requires testing for zero-diff model simulations. Something to keep in mind for now. We can decide later.

@gmao-rreichle gmao-rreichle marked this pull request as ready for review May 23, 2022 15:45
@gmao-rreichle gmao-rreichle requested review from a team as code owners May 23, 2022 15:45
@gmao-rreichle gmao-rreichle merged commit cad95dd into rreichle/cleanup/make_bcs May 23, 2022
@gmao-rreichle gmao-rreichle deleted the borescan/cleanup_scaling branch May 23, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants