-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R21C HISTORY output specs (precip, land, landice, ...) #637
R21C HISTORY output specs (precip, land, landice, ...) #637
Conversation
…ace, Catch, and VegDyn
GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/GEOS_SurfaceGridComp.F90
Show resolved
Hide resolved
GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/GEOS_SurfaceGridComp.F90
Show resolved
Hide resolved
GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/GEOS_SurfaceGridComp.F90
Show resolved
Hide resolved
…ichle/r21c_updates
…tional minor fixes to long names in Surface GC and Catch GC
My changes from /feature/lcandre2/r21c_landice_changes are now incorporated fully in this branch.
There is still one outstanding issue. 'RUNOFF' exported from 'SURFACE' in the flx collection should provide combined runoff from land and landice. However, a test indicated that the entire grid are no data values. 'RUNOFF' from LANDICE exports correctly, so the details of how this export propagates up through to SURFACE from LAND, LANDICE, & LAKE are beyond me. So, I am tagging @elakkraoui @sdrabenh @lltakacs |
Many thanks, @sdrabenh, for merging this PR. |
This PR proposes updated R21C HISTORY specs on top of @sdrabenh's R21C branch.
See also matching PR #356 in GEOSgcm_App
These updates will eventually need to find their way into the default and/or FP file specs in the 'develop' branch, which will require another PR.
Details:
Updates are focused on (but not entirely limited to) land and landice outputs.
For land outputs in the "lnd" collection, appended/inserted "LAND" in LONG_NAME wherever there's any chance at all that users could be confused that the output is only over land tiles.
Clarified LONG_NAME for volumetric soil moisture (m3/m3) vs dimensionless soil wetness.
Made variables that are exported in R21C consistent across land and landice (incl. runoff).
Fixed sign issue for GHTSKIN in landice.
Still to do:
Figure out how to deal with LONG_NAME of model vs. corrected precipitation. In MERRA-2, the words "bias corrected" were appended somehow to LONG_NAME for PRECTOTLAND and PRECSNOLAND.
a. "Bias corrected" is not a good term; going forward, we should use "observation corrected" because the corrections are applied at the daily scale.
b. Adding "observation corrected" to the LONG_NAME in *GridComp.F90 files requires thought because currently the F90 files supports both uncorrected and corrected precip over land in the same export variable.
Add runoff (and other variables?) averaged across land and landice. [DONE @lcandre2, @gmao-rreichle 16Nov22]
Resolve conflicting signs for GHTSKIN (GHLAND?) in landice and land collections. [DONE @lcandre2 16Nov22]
Resolve assorted in-line comments (to be added). [DONE @gmao-rreichle 17Nov22]
I'll keep working on this, but please feel free take a look and add your 2c.
For precip outputs, figure out how to clarify model vs. corrected in the LONG_NAME.
cc: @elakkraoui @lcandre2 @gmao-qliu @lltakacs @sdrabenh @rcullath @rdkoster @rlucches