Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R21C HISTORY output specs (precip, land, landice, ...) #637

Merged

Conversation

gmao-rreichle
Copy link
Contributor

@gmao-rreichle gmao-rreichle commented Sep 11, 2022

This PR proposes updated R21C HISTORY specs on top of @sdrabenh's R21C branch.
See also matching PR #356 in GEOSgcm_App
These updates will eventually need to find their way into the default and/or FP file specs in the 'develop' branch, which will require another PR.


Details:

Updates are focused on (but not entirely limited to) land and landice outputs.

For land outputs in the "lnd" collection, appended/inserted "LAND" in LONG_NAME wherever there's any chance at all that users could be confused that the output is only over land tiles.

Clarified LONG_NAME for volumetric soil moisture (m3/m3) vs dimensionless soil wetness.

Made variables that are exported in R21C consistent across land and landice (incl. runoff).

Fixed sign issue for GHTSKIN in landice.

Still to do:

  1. Figure out how to deal with LONG_NAME of model vs. corrected precipitation. In MERRA-2, the words "bias corrected" were appended somehow to LONG_NAME for PRECTOTLAND and PRECSNOLAND.
    a. "Bias corrected" is not a good term; going forward, we should use "observation corrected" because the corrections are applied at the daily scale.
    b. Adding "observation corrected" to the LONG_NAME in *GridComp.F90 files requires thought because currently the F90 files supports both uncorrected and corrected precip over land in the same export variable.

  2. Add runoff (and other variables?) averaged across land and landice. [DONE @lcandre2, @gmao-rreichle 16Nov22]

  3. Resolve conflicting signs for GHTSKIN (GHLAND?) in landice and land collections. [DONE @lcandre2 16Nov22]

  4. Resolve assorted in-line comments (to be added). [DONE @gmao-rreichle 17Nov22]

I'll keep working on this, but please feel free take a look and add your 2c.

For precip outputs, figure out how to clarify model vs. corrected in the LONG_NAME.

cc: @elakkraoui @lcandre2 @gmao-qliu @lltakacs @sdrabenh @rcullath @rdkoster @rlucches

@gmao-rreichle gmao-rreichle added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. Contingent - DNA These changes are contingent on other PRs (DNA=do not approve) labels Sep 11, 2022
@GEOS-ESM GEOS-ESM deleted a comment from rcullath Sep 16, 2022
@GEOS-ESM GEOS-ESM deleted a comment from rcullath Sep 16, 2022
@GEOS-ESM GEOS-ESM deleted a comment from rcullath Sep 16, 2022
@GEOS-ESM GEOS-ESM deleted a comment from rcullath Sep 16, 2022
@GEOS-ESM GEOS-ESM deleted a comment from rlucches Sep 16, 2022
@GEOS-ESM GEOS-ESM deleted a comment from rcullath Sep 16, 2022
@lcandre2
Copy link

lcandre2 commented Nov 23, 2022

My changes from /feature/lcandre2/r21c_landice_changes are now incorporated fully in this branch.

  1. long_name changes to RUNOFF from SURFACE and LANDICE (and other children of SURFACE to maintain consistency).

There is still one outstanding issue. 'RUNOFF' exported from 'SURFACE' in the flx collection should provide combined runoff from land and landice. However, a test indicated that the entire grid are no data values. 'RUNOFF' from LANDICE exports correctly, so the details of how this export propagates up through to SURFACE from LAND, LANDICE, & LAKE are beyond me. So, I am tagging @elakkraoui @sdrabenh @lltakacs

@sdrabenh sdrabenh merged commit e265148 into feature/sdrabenh/r21c_updates Dec 8, 2022
@gmao-rreichle
Copy link
Contributor Author

gmao-rreichle commented Dec 8, 2022

Many thanks, @sdrabenh, for merging this PR.
I double-checked that everything that was in the branch was merged ok, so I'm going to delete my branch. For any future changes that may be needed, we'll start with another clone of your most recent branch.
I'll also transfer the remaining to-do items into a new Github issue #683.
cc: @elakkraoui @lcandre2

@gmao-rreichle gmao-rreichle deleted the feature/rreichle/r21c_updates branch December 8, 2022 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. Contingent - DNA These changes are contingent on other PRs (DNA=do not approve)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants