Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve user interface of mk_runofftbl.F90 #693

Merged
merged 9 commits into from
Jan 17, 2023

Conversation

sanAkel
Copy link
Contributor

@sanAkel sanAkel commented Dec 27, 2022

This PR:

  • Provides a command line interface to mk_runofftbl.F90, with default inputs.
  • Optional arguments originate from this issue. Because the issue and thought process is evolving,
    • Optionally read in MAPL_tripolar.nc to fetch ocean mask via call to subroutine: read_oceanModel_mask currently returns nothing! However, it is available for future use in follow up PR.

✅ Answers remain unchanged.

@sanAkel sanAkel added documentation Improvements or additions to documentation 0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) labels Dec 27, 2022
@sanAkel sanAkel requested a review from a team as a code owner December 27, 2022 19:12
@sanAkel sanAkel self-assigned this Dec 27, 2022
@yvikhlya
Copy link
Contributor

Adjust ocean mask 303-317 should be done before anything else.

@sanAkel
Copy link
Contributor Author

sanAkel commented Dec 27, 2022

Adjust ocean mask 303-317 should be done before anything else.

9654fd7 Thanks @yvikhlya

sdrabenh
sdrabenh previously approved these changes Jan 4, 2023
gmao-rreichle
gmao-rreichle previously approved these changes Jan 4, 2023
Copy link
Contributor

@gmao-rreichle gmao-rreichle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust @sanAkel that this works as intended. Approving for Surface Preproc team.
One comment: There seems to be a minor grammatical issue in the following print statement:
print*, "Working on with input BCs string: ", file (Line 43)

to address @gmao-rreichle's (Thank you!) comment #693 (review)
@sanAkel sanAkel dismissed stale reviews from gmao-rreichle and sdrabenh via 0993258 January 4, 2023 21:22
@sdrabenh
Copy link
Collaborator

@sanAkel is this PR still something you pulled in to develop? If so, we need someone from the land team such as @gmao-rreichle to actually approve this PR. If not, we should close this PR.

@sanAkel
Copy link
Contributor Author

sanAkel commented Jan 17, 2023

@sanAkel is this PR still something you pulled in to develop? If so, we need someone from the land team such as @gmao-rreichle to actually approve this PR. If not, we should close this PR.

@sdrabenh, I think this can be pulled in. You need another review?

@gmao-rreichle already approved, see ⬇️
Screen Shot 2023-01-17 at 11 30 21 AM

@sdrabenh
Copy link
Collaborator

@sanAkel is this PR still something you pulled in to develop? If so, we need someone from the land team such as @gmao-rreichle to actually approve this PR. If not, we should close this PR.

@sdrabenh, I think this can be pulled in. You need another review?

@gmao-rreichle already approved, see arrow_down Screen Shot 2023-01-17 at 11 30 21 AM

@sanAkel OK I will pull in as soon as approved. @gmao-rreichle will need to re-approve since stale reviews were dismissed. GEOS-ESM/surface-preproc-team required to approve.

Copy link
Contributor

@gmao-rreichle gmao-rreichle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approving

@sdrabenh sdrabenh merged commit 002c0d1 into develop Jan 17, 2023
@sdrabenh sdrabenh deleted the feature/sanAkel/partial-fix-issue-681 branch January 17, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants