Use -O2 optimization in moist with GNU Release #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathomp4
added
the
0 diff
tclune
previously approved these changes
May 25, 2023
sdrabenh
approved these changes
Jun 5, 2023
bena-nasa
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing at NAS on the new TOSS4 nodes showed that GNU Release is currently not working (see GEOS-ESM/ESMA_cmake#317)
I had thought we'd need to degrade the optimization of GEOS GNU Release everywhere (even the LDAS) to
-O2which "solved" the issue.But it turns out I can just degrade it in Moist. So at least we don't cause issues for @gmao-rreichle and his folks. 馃槃
Now, this probably points to an issue in moist somewhere that this is hiding, but, it runs with Debug flags, so it's so obscure, it's hard to figure out.
Confirmed as zero-diff when running with Intel (as it should be).
NOTE: Labeling 0-diff as it is for Intel. It's non-zero-diff for GNU but well, no one runs GEOS in production with GNU.