-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
correct LONG_NAME for absorbed and emitted longwave flux in Surface #764
Conversation
…, Catch[CN], and Lake GridComps
…, Saltwater, Openwater, SimpleSeaice and CICE4ColumnPhys GridComps
I have committed in Landice, Saltwater, Openwater, SimpleSeaice and CICE4ColumnPhys gridcomps with the same LONGNAME corrections. |
Thanks @zhaobin74!! |
Marking this "ready for review" - still needs approval from the following teams: |
@gmao-rreichle Let me know if you'd like me to approve for @GEOS-ESM/land-team. I usually hold off as the approver of last resort only because my concern is usually "It builds, ship it!" I figure @rdkoster might be a bit more nuanced. 😄 |
Longwave radiation fluxes in Surface, Catch[CN], and Lake include only the absorbed and emitted portions of the fluxes and exclude the reflected portion. Variables are confusingly labeled "downwelling" and "upwelling/outgoing" throughout Surface, Catch[CN], and Lake. This PR fixes the corresponding LONG_NAME attributes of the Export and Import specs. Fortran variable names in the source code are not changed.
I did not look at the Landice and Saltwater GridComps. The @GEOS-ESM/landice-team and @GEOS-ESM/ocean-team may want to check their GridComps. If changes are needed, feel free to commit directly onto my branch, no need for a separate PR.
@gmao-jkolassa, please make sure these changes are copied into your CatchCTSMv5.1 GridComp branch.
The PR should be trivially 0-diff. Moreover, none of the impacted Exports are used in the standard HISTORY templates of the GEOSgcm_App, so the PR should have no impact on any of the current GEOS data products.
Net fluxes are not impacted because:
LW_NET = LW_UP - LW_DOWN = LW_ABSORBED - LW_EMITTED
To obtain upwelling longwave radiation from standard HISTORY output, use:
LW_UP = LW_DOWN - LW_NET = ( LW_ABSORBED / EMIS ) - LW_NET
cc: @rdkoster @weiyuan-jiang @biljanaorescanin @lcandre2 @rcullath @dr0cloud @rlucches