Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct LONG_NAME for absorbed and emitted longwave flux in Surface #764

Merged
merged 3 commits into from
Jun 7, 2023

Conversation

gmao-rreichle
Copy link
Contributor

Longwave radiation fluxes in Surface, Catch[CN], and Lake include only the absorbed and emitted portions of the fluxes and exclude the reflected portion. Variables are confusingly labeled "downwelling" and "upwelling/outgoing" throughout Surface, Catch[CN], and Lake. This PR fixes the corresponding LONG_NAME attributes of the Export and Import specs. Fortran variable names in the source code are not changed.

I did not look at the Landice and Saltwater GridComps. The @GEOS-ESM/landice-team and @GEOS-ESM/ocean-team may want to check their GridComps. If changes are needed, feel free to commit directly onto my branch, no need for a separate PR.

@gmao-jkolassa, please make sure these changes are copied into your CatchCTSMv5.1 GridComp branch.

The PR should be trivially 0-diff. Moreover, none of the impacted Exports are used in the standard HISTORY templates of the GEOSgcm_App, so the PR should have no impact on any of the current GEOS data products.

Net fluxes are not impacted because:

LW_NET = LW_UP - LW_DOWN = LW_ABSORBED - LW_EMITTED

To obtain upwelling longwave radiation from standard HISTORY output, use:

LW_UP = LW_DOWN - LW_NET = ( LW_ABSORBED / EMIS ) - LW_NET

cc: @rdkoster @weiyuan-jiang @biljanaorescanin @lcandre2 @rcullath @dr0cloud @rlucches

@gmao-rreichle gmao-rreichle added documentation Improvements or additions to documentation 0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) bugfix This fixes a bug labels Jun 4, 2023
@gmao-rreichle gmao-rreichle self-assigned this Jun 4, 2023
yvikhlya
yvikhlya previously approved these changes Jun 5, 2023
…, Saltwater, Openwater, SimpleSeaice and CICE4ColumnPhys GridComps
@zhaobin74
Copy link
Contributor

I have committed in Landice, Saltwater, Openwater, SimpleSeaice and CICE4ColumnPhys gridcomps with the same LONGNAME corrections.

@lcandre2
Copy link

lcandre2 commented Jun 6, 2023

I have committed in Landice, Saltwater, Openwater, SimpleSeaice and CICE4ColumnPhys gridcomps with the same LONGNAME corrections.

Thanks @zhaobin74!!

@gmao-rreichle
Copy link
Contributor Author

Marking this "ready for review" - still needs approval from the following teams:
@GEOS-ESM/land-team : @mathomp4 or @rdkoster)
@GEOS-ESM/seaice-team : @mathomp4, @sanAkel, or @zhaobin74
@GEOS-ESM/landice-team : @mathomp4, @zhaobin74, or @lcandre2

@gmao-rreichle gmao-rreichle marked this pull request as ready for review June 6, 2023 18:06
@gmao-rreichle gmao-rreichle requested review from a team as code owners June 6, 2023 18:06
@mathomp4
Copy link
Member

mathomp4 commented Jun 7, 2023

@gmao-rreichle Let me know if you'd like me to approve for @GEOS-ESM/land-team. I usually hold off as the approver of last resort only because my concern is usually "It builds, ship it!" I figure @rdkoster might be a bit more nuanced. 😄

@sdrabenh sdrabenh merged commit 1c198ae into develop Jun 7, 2023
9 checks passed
@sdrabenh sdrabenh deleted the bugfix/rreichle/Surface_Longwave_LONG_NAMES branch June 7, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) bugfix This fixes a bug documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants