Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor land related code cleanup (coeffsib) #845

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

biljanaorescanin
Copy link
Contributor

Code cleanup for unused statements of coeffsib.

@biljanaorescanin biljanaorescanin added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. cleanup labels Oct 18, 2023
@biljanaorescanin
Copy link
Contributor Author

@gmao-rreichle all agcm standard 1day testing was zero diff and intel GEOSldas Nightly Tests were zero diff as well. So FPP was indeed doing nothing.

@gmao-rreichle gmao-rreichle changed the title minor land related code cleanup minor land related code cleanup (coeffsib) Oct 18, 2023
@gmao-rreichle gmao-rreichle marked this pull request as ready for review October 18, 2023 20:08
@gmao-rreichle gmao-rreichle requested review from a team as code owners October 18, 2023 20:08
@gmao-rreichle
Copy link
Contributor

@mathomp4: Here, my first approval didn't take for the Land team. I then changed the from "Draft" to "Ready for Review", reapproved, and - voila - my 2nd approval now took for the Land team. Perhaps it's the difference between "Draft" and "Ready for Review" status that impacts the team-specific approval process?

@mathomp4
Copy link
Member

@mathomp4: Here, my first approval didn't take for the Land team. I then changed the from "Draft" to "Ready for Review", reapproved, and - voila - my 2nd approval now took for the Land team. Perhaps it's the difference between "Draft" and "Ready for Review" status that impacts the team-specific approval process?

Maybe? It's so weird. Maybe drafts do odd things with code owners. I think drafts came to GitHub after code owners so maybe that is a bug

@sdrabenh sdrabenh merged commit 32f555f into develop Nov 9, 2023
9 checks passed
@sdrabenh sdrabenh deleted the feature/borescan_cleanup_coeffsib branch November 9, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants