Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine check for allowable bcs versions to be run with CatchCN #882

Merged
merged 8 commits into from
Jan 26, 2024

Conversation

weiyuan-jiang
Copy link
Contributor

@weiyuan-jiang weiyuan-jiang commented Jan 17, 2024

mk_catchANDcnRestarts.F90 is used in remap_restarts.py and includes a check for bcs versions that are ok to run with CatchCN.
This PR refines this check and makes it possible to run CatchCN with newer bcs versions.

@weiyuan-jiang weiyuan-jiang requested a review from a team as a code owner January 17, 2024 15:34
@gmao-rreichle gmao-rreichle marked this pull request as draft January 17, 2024 15:46
@gmao-rreichle gmao-rreichle changed the title Feature/wjiang/no bc check Refine check for allowable bcs versions to be run with CatchCN Jan 17, 2024
@gmao-rreichle gmao-rreichle added 0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) bugfix This fixes a bug labels Jan 17, 2024
@gmao-rreichle gmao-rreichle marked this pull request as ready for review January 24, 2024 15:31
@sdrabenh sdrabenh merged commit 5ebbb7b into develop Jan 26, 2024
9 checks passed
@sdrabenh sdrabenh deleted the feature/wjiang/no_bc_check branch January 26, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) bugfix This fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants