bug fix: remove double-counting of heat corr (StieglitzSnow.F90) #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the rare circumstance that more snow would need to be sublimated than is available in the top layer, the residual energy accounting term was added twice, once here and again ~30 lines further down.
gmao-rreichle
added
Non 0-diff
|
The change is 0-diff for restarts and diagnostics in the full suite of GEOSldas nightly tests run by @gmao-rreichle on 17 Jun 2024. The next step is to run the GEOSgcm tests once @biljanaorescanin is back in the office. |
|
I am getting zero diff for all GCM testing. 1 day AMIP, REPLAY and INC REPLAY are all zero diff branch vs stock ( develop GEOSgcm_GridComp). The regression test is a success as well. |
gmao-rreichle
added
0 diff
biljanaorescanin
approved these changes
Jun 20, 2024
lcandre2
approved these changes
Jun 25, 2024
sdrabenh
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the rare circumstance when more snow would need to be sublimated than is available in the top layer, the residual energy accounting term was added twice, once here (in the changed line) and again ~30 lines further down.
This is a bug. It was discovered during the review of the land energy budget for M21C.
The fix is 0-diff in all standard GCM and LDAS tests. It remains unclear if the condition ever happens. If it does, it is so rare that it is not captured in the tests.
cc: @rdkoster