Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soil (and snow?) temperatures in units of Kelvin throughout ; do not write TSURF into "offline" catch restarts #114

Closed
gmao-rreichle opened this issue Feb 14, 2020 · 4 comments · Fixed by #340
Assignees

Comments

@gmao-rreichle
Copy link
Contributor

Work with the GCM group to convert all soil (and snow?) temperature EXPORT variables outside of catchment.F90 into units of Kelvin.
Currently, units are changed only at the level of the Surface Grid Comp or in the GEOSldas Ensemble GridComp, which is confusing because some EXPORTS are in Celsius and others in Kelvin.

@smahanam
Copy link

@weiyuan-jiang are you going to do this? Let me know if you want me to do it.

@gmao-rreichle gmao-rreichle changed the title soil (and snow?) temperatures in units of Kelvin throughout soil (and snow?) temperatures in units of Kelvin throughout ; do not write TSURF into "offline" catch restarts Feb 26, 2020
@gmao-rreichle
Copy link
Contributor Author

@smahanam : Because this change isn't guaranteed to be zero-diff, it's probably better to wait. I first need to talk with Scott to figure out a good opportunity to get this adopted into the GCM.

Another thing: When working on the GCM Grid Comp, we should also change the code such that TSURF is no longer written into "offline" catch restart files. This can be done by changing

RESTART = MAPL_RestartRequired

to

RESTART = RESTART

in the InternalSpecs definition of TSURF.

@smahanam
Copy link

TP1, TP2 ... are model diagnostics. This modification should pass AGCM zero-diff.
Perhaps, GEOSldas nightly test will fail, because the nightly tests (I think) diff all files.

@gmao-rreichle
Copy link
Contributor Author

@smahanam : It's true that this is zero-diff in terms of restarts. I'm not sure what exactly is tested for the AGCM. I also don't know if the AGCM team would accept a change that impacts diagnostics as easily as a truly zero-diff change. I hope to catch up with Scott next week and come up with a plan for getting this and other current, land-related "issues" into the GCM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment