Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add forecast error covariance inflation #203

Merged
merged 17 commits into from
May 5, 2020
Merged

Add forecast error covariance inflation #203

merged 17 commits into from
May 5, 2020

Conversation

gmao-rreichle
Copy link
Contributor

Addresses #136

gmao-qliu and others added 17 commits April 14, 2020 14:36
@gmao-qliu
update the cov inflation code
da6d227
@gmao-qliu
update clsm_ensupd_upd_routines.F90
1ca0224
@gmao-qliu
Merge branch 'develop' into feature/QL_cov_inflation_upd
2926ce3
@gmao-qliu
update output of inflated fcstvar
49fe0ec
@gmao-qliu
update
c0320e8
@gmao-qliu
keep branch updated with 'develop'
9fb0886 
Merge branch 'develop' into feature/QL_cov_inflation_upd
@gmao-qliu
Merge branch 'develop' into feature/QL_cov_inflation_upd
b7cca51
@gmao-qliu
update with 'develop'
41df1ee
@gmao-qliu
merge with 'develop'
beb7318
@gmao-qliu
Merge branch 'develop' into feature/QL_cov_inflation_upd
7c3a60b
@gmao-rreichle
cleanup of obsolete LDASsa code (mostly related to LDASsa binary output)
f226f21
@gmao-rreichle
additional cleanup
e979465
@gmao-rreichle
cleanup of obsolete increments output
15be328
@gmao-rreichle
Merge branch 'feature/RR_cleanup_Apr2020' into feature/RR_cov_inflation
5b2d819
@gmao-rreichle
additional modifications for model error covariance inflation
a46ab9f
@gmao-rreichle
syncing branch 'develop' into feature/RR_cov_inflation
65e5304
@gmao-rreichle
- renamed cov_inflation_factor -> fcsterr_inflation_fac
3779e15 
- minor cleanup
@gmao-rreichle gmao-rreichle added enhancement New feature or request 0-diff labels May 1, 2020
@gmao-rreichle gmao-rreichle self-assigned this May 1, 2020
@gmao-rreichle gmao-rreichle linked an issue May 1, 2020 that may be closed by this pull request
add forecast error covariance inflation #136
Closed
@gmao-rreichle
Copy link
Contributor Author

Verified and tested by @gmao-qliu (email of 1 May 2020):

With the default factor value (-9999). The branch passed nightly test with -t global on both sles11 and sles12.
With factor value of 1.2, I get the exactly same result as my version
"feature/QL_cov_inflation_upd".
I also ran the ctrl and cov_1 tests, all results are good and consistent.

@gmao-rreichle gmao-rreichle marked this pull request as ready for review May 1, 2020 20:10
@gmao-rreichle gmao-rreichle requested a review from a team as a code owner May 1, 2020 20:10
@gmao-rreichle gmao-rreichle merged commit 4f23307 into develop May 5, 2020
@gmao-rreichle gmao-rreichle deleted the feature/RR_cov_inflation branch May 5, 2020 21:26
@gmao-rreichle gmao-rreichle mentioned this pull request May 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiyuan-jiang weiyuan-jiang weiyuan-jiang approved these changes

Assignees

@gmao-rreichle gmao-rreichle

Labels
0-diff enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add forecast error covariance inflation
3 participants
@gmao-rreichle @weiyuan-jiang @gmao-qliu