Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup ("master", LDAS_ensdrv_vegalb_routines.F90) #258

Merged
merged 1 commit into from
Jun 19, 2020
Merged

cleanup ("master", LDAS_ensdrv_vegalb_routines.F90) #258

merged 1 commit into from
Jun 19, 2020

Conversation

gmao-rreichle
Copy link
Contributor

  • renamed variables (master_* --> root_*)
  • deleted obsolete file LDAS_ensdrv_vegalb_routines.F90

cc: @tclune

@gmao-rreichle
renamed "master_proc" and "master_logit" to "root_proc" and "root_log…
94ba699 
…it"; deleted obsolete file LDAS_ensdrv_vegalb_routines.F90
@gmao-rreichle gmao-rreichle requested a review from a team as a code owner June 19, 2020 10:58
@gmao-rreichle gmao-rreichle self-assigned this Jun 19, 2020
@gmao-rreichle gmao-rreichle linked an issue Jun 19, 2020 that may be closed by this pull request
remove LDAS_ensdrv_vegalb_routines.F90 #254
Closed
@gmao-rreichle
Copy link
Contributor Author

tested on 19 Jun 2020 by @gmao-rreichle

  • successfully built with Intel and GNU
  • successfully ran all test cases (Intel and GNU)
  • successful manual comparison of Intel test cases (tests currently undergoing transition to SLES12)

@mathomp4 mathomp4 mentioned this pull request Jun 19, 2020
Closed
mathomp4
mathomp4 approved these changes Jun 19, 2020
View reviewed changes
Copy link
Member

@mathomp4 mathomp4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and I know @gmao-rreichle tests. Approved!

@gmao-rreichle gmao-rreichle merged commit 1302089 into develop Jun 19, 2020
@gmao-rreichle gmao-rreichle deleted the RR_rename_master branch June 19, 2020 12:40
@gmao-rreichle gmao-rreichle mentioned this pull request Jun 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathomp4 mathomp4 mathomp4 approved these changes

Assignees

@gmao-rreichle gmao-rreichle

Labels
0-diff cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove LDAS_ensdrv_vegalb_routines.F90
2 participants
@gmao-rreichle @mathomp4