Develop #292
Merged
Develop #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…GEOSldas pre-processing (#283) - Improved documentation of bug in some EASE *.til files (header says N_grid=1 but has lines for two grid defs in header) - Introduced tile type MAPL_Land_ExcludeFromDomain - Added consistency checks in createLocalTilefile() - Collected subroutines and functions needed only in pre-processing into single file preprocess_ldas_routines.F90. Executed in three consecutive git commits: Commit 1 of 3: - renamed: src/Applications/LDAS_App/preprocess_ldas.F90 -> src/Applications/LDAS_App/preprocess_ldas_routines.F90 - deleted: src/Applications/LDAS_App/preprocess_ldas_subs.F90 - deleted: src/Components/GEOSldas_GridComp/Shared/LDAS_ensdrv_init_routines.F90 Commit 2 of 3: - collected subroutines and functions that are only needed in preprocessing into a single new file: preprocess_ldas_routines.F90, including - all subroutines from preprocess_ldas.F90 - LDAS_read_til_file() [from LDAS_TileCoordRoutines.F90] - read_grid_elev() [helper subroutine] - fix_dateline_bug_in_tilecoord() [helper subroutine] - read_catchment_def() [helper subroutine] - domain_setup() [from LDAS_ensdrv_init_routines.F90] - read_exclude_or_includelist() [helper subroutine] - read_cat_param() [helper subroutine] - moved subroutine io_domain_files() from LDAS_ensdrv_init_routines.F90 to LDAS_TileCoordRoutines.F90 - deleted LDAS_ensdrv_init_routines.F90 Commit 3 of 3: - added preprocess_ldas.F90 (main program only) back into git Moved additional subroutines and functions that are only used in LDAS pre-processing to preprocess_ldas_routines.F90: - is_cat_in_box() [from LDAS_TileCoordRoutines.F90] - is_in_list() [from LDAS_ensdrv_functions.F90] - is_in_domain() [from LDAS_ensdrv_functions.F90] - word_count() [from LDAS_ensdrv_functions.F90] - open_land_param_file() [from LDAS_ensdrv_functions.F90] Commented out obsolete subroutines and functions: - io_mwRTM_param_type() [in mwRTM_types.F90] - mwRTM_get_param() [in mwRTM_routines.F90] - int2char2() [in LDAS_ensdrv_function.F90] - int2char4() [in LDAS_ensdrv_function.F90] - timetag() [in LDAS_ensdrv_function.F90] - mydate() [in LDAS_ensdrv_function.F90]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update the branch