Updates to CatchCN GridComp so it can reproduce Fanwei's science-tested LDASsa version of CatchCN #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmao-rreichle
changed the title
gmao-rreichle
added
0-diff
enhancement
…SM/GEOSldas into feature/jkolassa_#287_fixes_match
|
Addressed with additional comments in PR #349. |
Changed GEOSgcm_GridComp branch to 'develop' since PR#349 has been merged into develop.
gmao-rreichle
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch contains a code modification needed to run GEOSldas with GEOSgcm_GridComp branch feature/jkolassa_#287_fixes that is currently submitted as draft pull request https://github.com/GEOS-ESM/GEOSgcm_GridComp/pull/349. The specific modification is:
GEOS_LdasGridComp.F90:
• Added LSM_CHOICE to SurfParams_init call in Initialize subroutine
This pull request should be approved shortly after GEOSgcm_GridComp pull request #349 is approved.
cc: @gmao-rreichle , @biljanaorescanin , @smahanam , @rdkoster , @gmao-jkolassa