Hotfix/no_tiles_in process #316
Conversation
weiyuan-jiang
commented
Sep 24, 2020
weiyuan-jiang
commented
- fix the situation when there is no tiles in a process
- Determine NUM_LDAS_ENSEMBLE entry in lenkf.j from LDAS.rc, replacing the independent, ldas_setup-generated specification in lenkf.j
- use the relative link path. When the whole directory is moved (like CURRENT to BASELINE) the link would be still valid.
2) Determine NUM_LDAS_ENSEMBLE entry in lenkf.j from LDAS.rc, replacing the independent, ldas_setup-generated specification in lenkf.j
|
@weiyuan-jiang : I (re-)fixed the use of the optional argument "obsbias_ok_tmp" and added a few comments, see commit |
|
good catch. I have test this branch and it seems zero-diff |
There was a problem hiding this comment.
Approved. I understand the comment by @weiyuan-jiang to mean that the branch is 0-diff vs develop in the current test suite. What remains to be seen is if the branch is 0-diff between the (old) 1d decomposition (w/ optimization) and the new 2d decomposition functionality.
In any case, I'm ok with merging the branch at this time because it is 0-diff in the current test suite and because it fixes other things.
But we may need additional modifications to achieve 0-diff between the 1d and 2d decompositions.
cc: @biljanaorescanin
