PARdffs bug fix and add time step for sun angle #53
Conversation
|
though it's named hotfix, this should NOT be merged into master at this time |
There was a problem hiding this comment.
I ran 24 hours with 5min output to eval these impacts
/home/jperket/project/ldas/GlobalTest.1/run
/home/jperket/project/ldas/GlobalCSTest.1/run
we can compare these with the tests for the related pull request #52 , that only has the solar timestep, and not the par bug fix
/home/jperket/project/ldas/GlobalTest.0/run
/home/jperket/project/ldas/GlobalCSTest.0/run
and the control, develop runs:
/home/jperket/project/ldas/GlobalDevelop/run
/home/jperket/project/ldas/GlobalCSDevelop/run
The PAR bug is an obvious fix to be accepted. For the solar time stepping fix #52 , It looks like we could be shifting diurnal/annual mean downwelling solar. Perhaps we should look into that more, @gmao-rreichle
I'll take a look at the "solar time stepping" output. The PAR pert fix test run ("GlobalTest.1") has zero-diff final restart w/ its control ("GlobalTest.0"). This is because PAR perts do not get exercised for model-only, no perturbations runs such as GlobalTest.[x]. We do need the assim test for this. |
Oh, yes, of course. Duh |
There was a problem hiding this comment.
Now ready to merge, approved by @gmao-rreichle . Closing #51
No description provided.