fix character length #572
Closed
fix character length #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looks good to me. Not sure if a formal test was done, or if it's needed. Could be considered "0-diff trivial", and the build works.
However, this PR cannot just be merged because this PR has a "conflict" with #569, which moves around some of the utilities that are changed in this PR. That is, some of the changes here would be lost unless they are also added to #569.
Merging this PR therefore requires more thought/discussion.
|
I have tested it. It is zero-diff |
|
Replaced with #574. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase the filenames' ( with path) length so the filenames don't get truncated.