Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify help message for "lenkf.j -debug" #591

Merged
merged 6 commits into from
Oct 18, 2022
Merged

Clarify help message for "lenkf.j -debug" #591

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
58b4b5f
load and launch totalview in lenkf.j
weiyuan-jiang Oct 13, 2022
8902c42
additional edits for debug mode (lenkf.j.template)
gmao-rreichle Oct 13, 2022
f6251ed
fixing previous commit
gmao-rreichle Oct 13, 2022
9fa58d0
undoing conditional around source g5_modules (lenkf.j.template)
gmao-rreichle Oct 14, 2022
a9f084b
minor revisions to debugging instructions
gmao-rreichle Oct 17, 2022
1e933c5
Merge branch 'develop' into feature/wjiang/load_launch_tview
gmao-rreichle Oct 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/Applications/LDAS_App/lenkf.j.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@ endif
unset argv
setenv argv

source $GEOSBIN/g5_modules
if ( $debug_flag == 0 ) then
source $GEOSBIN/g5_modules
endif
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is meant to take care of @gmao-qliu's suggestion to avoid "source g5_modules" when in debug mode.
If this works, then I'm not sure why we would need unset argv; setenv argv above that was introduced to avoid g5_modules tripping up when lenkf.j is called with the -debug flag. Maybe the suggestion to omit "source g5_modules" here won't work? I'm getting really confused.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since '-debug" option only prints out information, I would like to change it to "--help". It prints out and exits before source g5_modules

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weiyuan-jiang : I don't think --help is good here. Doesn't -debug run all of the preprocessing and stops only when it's time to run GEOSldas.x? In other words, -debug does not just print out info.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having said that, does the preprocessing possibly need "source g5_modules"? @gmao-qliu: Did you verify that we can skip "source g5_modules" when running with -debug?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the preprocessing is not necessary for debug. Except users change the directory to scratch and launch totalview

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having said that, does the preprocessing possibly need "source g5_modules"? @gmao-qliu: Did you verify that we can skip "source g5_modules" when running with -debug?

actually "source g5_modules" is needed with -debug because otherwise $BASEDIR is undefined. I take my suggestion back.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After users finish ldas_setup and get the interactive nodes, they can go to the "run" directory, source ../build/bin/g5_modules.sh , then load and launch totalview in run directory

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weiyuan-jiang : Are you seriously saying that the first 200-300 lines in lenkf.j are not needed? If that's the case, why can't we just delete them altogether?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weiyuan-jiang, maybe what you are suggesting is to run in debug mode from a crashed experiment directory? Otherwise, how can we do without preprocess_ldas.x ?
I think we should keep -debug such that it exactly replicates what sbatch lenkf.j would do.


setenv I_MPI_DAPL_UD enable

Expand Down Expand Up @@ -385,9 +387,10 @@ while ( $counter <= ${NUM_SGMT} )
echo ""
echo "lenkf.j -debug:"
echo ""
echo "To start debugging, you must now manually launch your debugging tool"
echo "with GEOSldas.x from here, e.g.,"
echo "To start debugging, you must now manually source g5_modules and launch"
echo "your debugging tool with GEOSldas.x from here, e.g.,"
echo ""
echo " source $GEOSBIN/g5_modules [for bash or zsh: source g5_modules.[z]sh]"
echo " totalview $GEOSBIN/GEOSldas.x"
echo ""
echo "Availability of tools depends on the computing system and may require"
Expand Down