Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a script for rewinding an existing ldas run #606

Merged
merged 4 commits into from
Dec 9, 2022

Conversation

saraqzhang
Copy link
Contributor

a standalone script that rewinds ldas run when in need of re-sync restart date/time in ldas and adas

@saraqzhang saraqzhang requested a review from a team as a code owner December 7, 2022 22:23
@github-actions
Copy link

github-actions bot commented Dec 7, 2022

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found:

@saraqzhang saraqzhang added enhancement New feature or request 0-diff trivial very, very obvious 0-diff change labels Dec 7, 2022
@saraqzhang
Copy link
Contributor Author

@gmao-rreichle
the script is put in src/Applications/LDAS_App/util/shared/.

@gmao-rreichle
Copy link
Contributor

@saraqzhang, many thanks for adding the script! I made a few edits to clean it up a bit and also moved it to ./config, for lack of a better idea. In the broader sense, the script deals with setting up (configuring) an experiment, so it's probably ok there.
Please double-check my changes. Here's my commit with the edits (before the file was moved and renamed):
646f32a?w=1
Note that this link suppresses white-space changes.
Here's the same again with the white-space changes, which could be important for a csh script.
646f32a
I hope I didn't mess it up.

@saraqzhang
Copy link
Contributor Author

@gmao-rreichle the edited version is cleaner and all correct. config/ is a more suitable dir to be .

@gmao-rreichle gmao-rreichle requested a review from a team as a code owner December 9, 2022 14:27
Copy link
Contributor

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmake changes ok

Copy link
Contributor

@gmao-rreichle gmao-rreichle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weiyuan-jiang, @GEOS-ESM/cmake-team, please take a quick look at this small PR and, if ok, approve the CMake changes. Thanks!

@gmao-rreichle gmao-rreichle merged commit 07496d6 into develop Dec 9, 2022
@gmao-rreichle gmao-rreichle deleted the feature/saraqzhang/addrewindcsh branch December 9, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-diff trivial very, very obvious 0-diff change enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants