Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update paths to use new inputs area #615

Merged
merged 13 commits into from
Mar 6, 2023

Conversation

biljanaorescanin
Copy link
Contributor

@biljanaorescanin biljanaorescanin commented Dec 29, 2022

Matching PR for GEOS-ESM/GEOSgcm_GridComp#694
Updates for reorganization of GCM GC ./Raster dir: GEOS-ESM/GEOSgcm_GridComp#707

@weiyuan-jiang
Copy link
Contributor

The last commit tried to address issue #627

@gmao-rreichle
Copy link
Contributor

@weiyuan-jiang, we added:
GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/Utils/Raster/makebcs/LDAS_DateTimeMod.F90
to the GCM GC branch associated with the present GEOSldas PR. But we still have
src/Components/GEOSldas_GridComp/Shared/LDAS_DateTimeMod.F90
in the LDAS branch. That is, currently there should be two identical copies of the LDAS_DateTimeMod library floating around in the LDAS build. Can we just delete the F90 file in the LDAS?

@weiyuan-jiang
Copy link
Contributor

Yes, I believe we can delete it in GEOSldas

@biljanaorescanin
Copy link
Contributor Author

biljanaorescanin commented Mar 2, 2023

PR testing summary from @gmao-jkolassa:

She tested following four configurations:

CatchCN4.0 with ATM_CO2 = 1
CatchCN4.0 with ATM_CO2 = 2
CatchCN4.5 with ATM_CO2 = 1
CatchCN4.5 with ATM_CO2 = 2
For each configuration she ran an experiment with GEOSldas 'develop' and this branch and compared the restart files after 1 month. In all cases, the restart files are identical. She also checked the log and error files and nothing in there indicated that the CO2 file is not being read correctly.

gmao-rreichle and others added 3 commits March 2, 2023 16:54
…(GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/Utils/Raster/makebcs/LDAS_DateTimeMod.F90)
@gmao-rreichle gmao-rreichle marked this pull request as ready for review March 6, 2023 20:33
@gmao-rreichle gmao-rreichle requested review from a team as code owners March 6, 2023 20:33
Copy link
Contributor

@gmao-rreichle gmao-rreichle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reapproving

Copy link
Member

@mathomp4 mathomp4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for cmake!

@gmao-rreichle gmao-rreichle merged commit 94989a3 into develop Mar 6, 2023
@gmao-rreichle gmao-rreichle deleted the feature/borescan_restr_bcs_inputs branch March 6, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants