Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up variable and subroutine names for Ldas grid #637

Merged
merged 13 commits into from
Mar 22, 2023
Merged

clean up variable and subroutine names for Ldas grid #637

merged 13 commits into from
Mar 22, 2023

Conversation

weiyuan-jiang
Copy link
Contributor

Use pert_grid as the standard names for perturbation and assimilation

@weiyuan-jiang weiyuan-jiang requested a review from a team as a code owner March 10, 2023 18:37
@gmao-rreichle
Copy link
Contributor

Thanks, @weiyuan-jiang, for putting this together. I applied a couple of small commits that should further clean up the code and hope I didn't break anything. I'm not sure the renaming is done in all the right places quite yet. See inline comment above. Additionally, perhaps we need to rename tile_grid -> pert_grid in subroutine get_obs_pred(). I haven't really finished this review and will need to revisit the PR later, but I wanted to write down my thoughts up to this point.

@gmao-rreichle gmao-rreichle mentioned this pull request Mar 17, 2023
Merged
@gmao-rreichle gmao-rreichle marked this pull request as draft March 18, 2023 20:07
@github-actions
Copy link

This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged.

@github-actions
Copy link

This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged.

@github-actions
Copy link

This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged.

@github-actions
Copy link

This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged.

@biljanaorescanin
Copy link
Contributor

All Nightly Tests passed on the branch.

@gmao-rreichle gmao-rreichle marked this pull request as ready for review March 22, 2023 15:28
@gmao-rreichle gmao-rreichle merged commit 6a83bf1 into develop Mar 22, 2023
@gmao-rreichle gmao-rreichle deleted the feature/wjiang/clean_grid_name branch March 22, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@biljanaorescanin biljanaorescanin biljanaorescanin left review comments

@gmao-rreichle gmao-rreichle gmao-rreichle approved these changes

Assignees
No one assigned
Labels
0-diff cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@weiyuan-jiang @gmao-rreichle @biljanaorescanin