Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix problems and duplication with MATLAB tools for EASEv2 latlon2ind #640

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

gmao-rreichle
Copy link
Contributor

PR fixes issues with Matlab tool for EASEv2 lat/lon-to-index mapping:

  • Added optional input argument to EASEv2_latlon2ind() that controls rounding of [row, col] before returning.
  • Removed duplicate smapeasev2_latlon2ind() function from write_smapL4SMqa.m.

@amfox37, @gmao-qliu: Please review the changes.

cc: @biljanaorescanin

Copy link
Contributor

@amfox37 amfox37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested all but the mwRTM-related code, and things work as they should when using get_model_and_obs_clim_stats

@biljanaorescanin biljanaorescanin marked this pull request as ready for review April 12, 2023 15:18
@biljanaorescanin biljanaorescanin requested a review from a team as a code owner April 12, 2023 15:18
@gmao-rreichle gmao-rreichle merged commit 5297be2 into develop Apr 12, 2023
@gmao-rreichle gmao-rreichle deleted the rreichle/bugfix/matlab_EASEv2_latlon2ind branch April 12, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-diff trivial very, very obvious 0-diff change bug fix matlab utils
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants