Add Mironov soil dielectric mixing model and rough reflectivity parameter options #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is being prevented from merging because you have not added one of our required labels: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Please add one so that the PR can be merged. |
gmao-rreichle
changed the title
|
Thanks, @gmao-qliu, for putting this together. I made a few quick edits:
|
gmao-qliu
commented
May 9, 2023
src/Components/GEOSldas_GridComp/GEOSlandassim_GridComp/mwRTM_routines.F90
Outdated
Show resolved
Hide resolved
src/Components/GEOSldas_GridComp/GEOSlandassim_GridComp/mwRTM_routines.F90
Show resolved
Hide resolved
gmao-qliu
commented
May 9, 2023
src/Components/GEOSldas_GridComp/GEOSlandassim_GridComp/GEOS_LandAssimGridComp.F90
Show resolved
Hide resolved
gmao-qliu
commented
May 10, 2023
…p.F90; mwRTM_routines.F90)
|
successfully 0-diff tested by @gmao-rreichle |
|
My most recent commit #1333041 is trivially 0-diff for the LDAS nightly tests, and re-testing is not needed. The changes in subroutine Mironov() seem simple enough but an error would impact the new mwRTM. |
gmao-rreichle
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gmao-rreichle Preliminary version with the updated mwRTM including mironov soil dielectric model and other parameters based on the SMAP Level 2 DCA algorithm. RTM_id is used but we need to think about how to get the value when land_assim is set to "false".