Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update components.yaml to match GEOSgcm, update GitHub Actions and CircleCI #667

Merged
merged 3 commits into from
Jul 5, 2023

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Jul 3, 2023

This PR is mainly an update to the components.yaml with the following updates:

  • MAPL v2.39.1 -> v2.39.4 (a few bug fixes)
  • ESMA_env v4.16.0 -> v4.17.0 (Baselibs 7.13.0)
  • ESMA_cmake v3.28.0 -> v3.30.0 (Remove BUILT_ON_ROME check for NAS, add QUIET_DEBUG flag)
  • GMAO_Shared v1.9.0 -> v1.9.1 (CICE4 now a shared library)
  • GEOS_Util v2.0.1 -> v2.0.2 (plot updates)

These should all be zero-diff. The MAPL updates are bugfixes for sort of corner cases a few people hit.

ESMA_env did update Baselibs, but GEOSldas already absorbed the non-zero-diff ESMF change (the latest version has updates required for MAPL 2.40).

The ESMA_cmake change has no impact, and I think GEOSldas ignores CICE4 in GMAO_Shared.

This also updates the GitHub Actions to the latest versions therein and updates the Baselibs version in the CircleCI control file.

@mathomp4 mathomp4 added the 0-diff label Jul 3, 2023
@mathomp4 mathomp4 self-assigned this Jul 3, 2023
@mathomp4 mathomp4 requested review from a team as code owners July 3, 2023 23:48
@mathomp4 mathomp4 marked this pull request as draft July 3, 2023 23:49
@gmao-rreichle
Copy link
Contributor

Thanks, @mathomp4, for keeping us current. While we're at it, should we throw in GEOS_Util v2.0.2?
@biljanaorescanin, once @mathomp4 has weighed in on updating GEOS_Util, please go ahead and run the full suite of GEOSldas nightly tests when you get a chance.

@mathomp4
Copy link
Member Author

mathomp4 commented Jul 4, 2023

Oh. Huh. Yeah, might as well. I guess I didn't see it since GEOSgcm doesn't have it yet (and you had v2.0.1 ahead of it!). I'll update the PR.

@biljanaorescanin
Copy link
Contributor

All tests passed.

@biljanaorescanin biljanaorescanin marked this pull request as ready for review July 5, 2023 16:59
@gmao-rreichle gmao-rreichle merged commit a51cb0c into develop Jul 5, 2023
7 checks passed
@gmao-rreichle gmao-rreichle deleted the feature/mathomp4/update-components-ldas branch July 5, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants