Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up and save fft panel #679

Merged
merged 9 commits into from
Nov 7, 2023
Merged

Conversation

weiyuan-jiang
Copy link
Contributor

@weiyuan-jiang weiyuan-jiang commented Oct 23, 2023

Summary of changes:

  1. FFT for generation of perturbations:
    a) check the status of fft calls
    b) save fft panels to avoid initializiing and finalizing fft environment every time
  2. added cat_diagS_max function to avoid NaN issue when computing ens std-dev Possible NaN is introduced #678
  3. clean up of unused variables

All LDAS nightly tests passed (incl. Intel, aggressive, and GNU) after most recent commit b5fe7b1

biljanaorescanin and others added 6 commits November 2, 2023 14:03
…(clsm_ensupd_enkf_update.F90, GEOS_LandAssimGridComp.F90)
…iagS_sqrt() (catch_types.F90, GEOS_LandAssimGridComp.F90)
…idComp.F90, clsm_ensupd_enkf_update.F90, GEOS_LandPertGridComp.F90, LDAS_PertRoutines.F90, land_pert.F90, random_fields.F90)
@gmao-rreichle gmao-rreichle marked this pull request as ready for review November 7, 2023 14:16
@gmao-rreichle gmao-rreichle requested a review from a team as a code owner November 7, 2023 14:16
@gmao-rreichle gmao-rreichle merged commit 5da35a6 into develop Nov 7, 2023
11 checks passed
@gmao-rreichle gmao-rreichle deleted the feature/wjiang/optimize_fft branch November 7, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants