Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GEOSldas work for SLES15 / Milan #693

Merged
merged 11 commits into from
Feb 8, 2024

Conversation

weiyuan-jiang
Copy link
Contributor

Address issue #691 and added support for SLES15

@gmao-rreichle gmao-rreichle changed the title Feature/wjiang/openmpi flag Make GEOSldas work for SLES15 / Milan Jan 17, 2024
@biljanaorescanin
Copy link
Contributor

All Nightly Tests passed on SLES-12.
I was able to run few day experiment on SLES-15.
If we wish to run Nightly Tests on SLES-15 some changes are still needed.

@gmao-rreichle
Copy link
Contributor

@biljanaorescanin ran the Nightly Tests on SLES15 and reports only roundoff differences. (The CNCLM45 test fails to run on GNU because of a floating point exception, which is addressed here: GEOS-ESM/GEOSgcm_GridComp#898.)

I further verified that @biljanaorescanin's LDAS_GLOBAL/assim test on SLES-15 has only roundoff differences based on my usual plots of the brightness temperature O-Fs and A-Fs.

@gmao-rreichle
Copy link
Contributor

@GEOS-ESM/cmake-team : Can you please approve this PR or let us know what might need changing? Thanks!

@mathomp4
Copy link
Member

mathomp4 commented Feb 8, 2024

@GEOS-ESM/cmake-team : Can you please approve this PR or let us know what might need changing? Thanks!

@gmao-rreichle We can't approve until it is no longer draft. But the Cmake looks fine to me.

@gmao-rreichle gmao-rreichle marked this pull request as ready for review February 8, 2024 20:38
@gmao-rreichle gmao-rreichle requested review from a team as code owners February 8, 2024 20:38
@gmao-rreichle gmao-rreichle merged commit 7e0a22b into develop Feb 8, 2024
5 checks passed
@gmao-rreichle gmao-rreichle deleted the feature/wjiang/openmpi_flag branch February 8, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants