Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "update_type" for joint assimilation of ASCAT SM and SMAP Tb #703
Add "update_type" for joint assimilation of ASCAT SM and SMAP Tb #703
Changes from 22 commits
4373200
031911c
a6e3341
8c13068
3fc6ee1
4fb9e6a
af05a5c
6e079f8
ef970ab
3d6615f
0771402
194fbbe
718a55a
b9dc1df
d8b8160
4b878f0
7cc3735
3f18420
9637304
687d17b
e79c437
bc0cef5
d450550
7e5b3c8
958233c
f478091
e78cc6b
47d4bb9
9f02392
175ccb5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the "trim()" function here, and similarly in the next two blocks? I wonder if the "==" statement reliably produces the desired result across compilers, given that we should have trailing whitespace in %varname.
Note that obs_param is dimension(N_obs_param). Not sure if trim() works on such a 1d array.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to simplify this block by teaching the
get_ind_obs_lat_lon_box()
(or the relatedget_ind_obs()
) subroutine to (optionally) return a vector of the unique species numbers associated with the obs in ind_obs? This would be useful when we're adding new multi-sensor update_types in the future.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we shouldn't look at the sensitivity of the ASCAT analysis to including/excluding catdef in the state vector. My gut feeling is that catdef shouldn't be included in the state vector, based on the history of the Tb assimilation. It's included in update_type=2 more for historical reasons than anything else. If catdef should be excluded from the state vector, we might want to settle this in the code sooner rather than later, and definitely before we start publishing results. Something to discuss on Monday.