Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support NAS site #706

Merged
merged 6 commits into from
Feb 24, 2024
Merged

support NAS site #706

merged 6 commits into from
Feb 24, 2024

Conversation

weiyuan-jiang
Copy link
Contributor

Add support to NAS site

@weiyuan-jiang weiyuan-jiang added enhancement New feature or request 0-diff labels Feb 13, 2024
@gmao-rreichle
Copy link
Contributor

I tested the PR successfully on NCCS/Discover for LDAS_CONUS, LDAS_GLOBAL, LDAS_DEBUGCONUS, and LDAS_GNUCONUS, which is a sufficient subset of tests for this PR.
@weiyuan-jiang : Please note on the PR when you had a chance to verify that GEOSldas runs at NAS.

@gmao-rreichle
Copy link
Contributor

@weiyuan-jiang : I just noticed the merge conflict for this branch. Please resolve it when you get a chance. Thanks!

@weiyuan-jiang
Copy link
Contributor Author

@weiyuan-jiang : I just noticed the merge conflict for this branch. Please resolve it when you get a chance. Thanks!

resolved.

@weiyuan-jiang
Copy link
Contributor Author

@gmao-rreichle It runs on NAS

Copy link
Contributor

@gmao-rreichle gmao-rreichle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I successfully ran the LDAS_CONUS test on Discover.

@gmao-rreichle gmao-rreichle marked this pull request as ready for review February 24, 2024 14:07
@gmao-rreichle gmao-rreichle requested a review from a team as a code owner February 24, 2024 14:07
@gmao-rreichle gmao-rreichle merged commit d3488b2 into develop Feb 24, 2024
5 checks passed
@gmao-rreichle gmao-rreichle deleted the feature/wjiang/NAS_support branch February 24, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-diff enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants