Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sparse checkout of GEOS_util #711

Merged
merged 4 commits into from
Feb 21, 2024
Merged

Conversation

weiyuan-jiang
Copy link
Contributor

@weiyuan-jiang weiyuan-jiang commented Feb 15, 2024

This PR needs GEOS Util PR#58

@gmao-rreichle
Copy link
Contributor

@weiyuan-jiang : Did you test this PR (using the GEOS_Util feature branch)? I suppose that would also count as a test of https://github.com/GEOS-ESM/GEOS_Util/pull/58/files. I imagine Scott would also need us to test GEOS-ESM/GEOS_Util#58 with the GCM, which @biljanaorescanin could do. If GEOS-ESM/GEOS_Util#58 is ready, now's a good time to elevate it to "ready for review" and get Scott's attention. (We also have GEOS-ESM/GEOS_Util#53 waiting for Scott.)

@weiyuan-jiang
Copy link
Contributor Author

weiyuan-jiang commented Feb 16, 2024

@weiyuan-jiang : Did you test this PR (using the GEOS_Util feature branch)? I suppose that would also count as a test of https://github.com/GEOS-ESM/GEOS_Util/pull/58/files. I imagine Scott would also need us to test GEOS-ESM/GEOS_Util#58 with the GCM, which @biljanaorescanin could do. If GEOS-ESM/GEOS_Util#58 is ready, now's a good time to elevate it to "ready for review" and get Scott's attention. (We also have GEOS-ESM/GEOS_Util#53 waiting for Scott.)

I have built it but not tested. I assumed GEOS_Util 's PR is good to go

@gmao-rreichle
Copy link
Contributor

I have built it but not tested. I assumed GEOS_Util 's PR is good to go

@weiyuan-jiang: GEOS-ESM/GEOS_Util#58 (58) was started by you and is in draft form, without documentation or notes about testing. Maybe you confused 58 with GEOS-ESM/GEOS_Util#53 (53) when you wrote that you "assumed GEOS_Util 's PR is good to go"?

@weiyuan-jiang
Copy link
Contributor Author

I have built it but not tested. I assumed GEOS_Util 's PR is good to go

@weiyuan-jiang: GEOS-ESM/GEOS_Util#58 (58) was started by you and is in draft form, without documentation or notes about testing. Maybe you confused 58 with GEOS-ESM/GEOS_Util#53 (53) when you wrote that you "assumed GEOS_Util 's PR is good to go"?

Oh, I mean both PRs in GEOS_Util are ready.

@gmao-rreichle gmao-rreichle marked this pull request as ready for review February 21, 2024 23:04
@gmao-rreichle gmao-rreichle requested review from a team as code owners February 21, 2024 23:04
@gmao-rreichle gmao-rreichle merged commit 20c9649 into develop Feb 21, 2024
5 checks passed
@gmao-rreichle gmao-rreichle deleted the feature/wjiang/sparse_util branch February 21, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants