-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Extract GEOSldas_GridComp and LDAS_App into separate repos #712
Conversation
I suppose up next would be to have @biljanaorescanin test to see if this does more than build! :) |
@mathomp4, thanks for putting this PR and the Github Project together, very helpful. I'm starting to understand what this all means. Here are a couple of initial thoughts:
|
@gmao-rreichle You are the closest to the issue. I have no strong opinions. I will point out that it is easier to split again later on than to undo a split that you come to regret. |
@gmao-rreichle I mean, there is no reason that We could put My guess is the best way to do this is I'd first make a PR to GEOSldas where all we do is a |
Update: Okay. I can also do it in my extraction process too. The one thing is it looks like that way the history is not retained. This might not be a bad thing, we can just tell people this history for GEOSldas_App is in the GEOSldas repo. But I'll keep trying things... |
This PR will be superseded by a new one. Closing. |
This is a work-in-progress PR for extracting out the
GEOSldas_GridComp
andLDAS_App
directories into their own components (for work with @saraqzhang and @rtodling in integrating LDAS into the ADAS).Using RepoExtractor, the two repos were extracted with:
In my test it built. Which is nice.
NOTE 1: This should not be depended on. Most likely the two new repos will need to be deleted and remade once this is done "for real"
NOTE 2: In this PR, I kept GEOSgcm_GridComp underneath GEOSldas_GridComp. It could be moved parallel as well. CMake doesn't care, but in this way the directory tree before and after will look nigh the same