Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support reading corrected precipitation from aggregated daily netcdf files #718

Merged
merged 5 commits into from
Feb 26, 2024

Conversation

gmao-qliu
Copy link
Contributor

To reduce the number of files on disk, we can aggregate the 24 hourly corrected precipitation files into 1 daily file. The updates support reading from both hourly and daily (if no hourly file is found) files.

@gmao-rreichle
Copy link
Contributor

I successfully tested the branch after my minor updates. @gmao-qliu, did you verify that the new functionality of reading from daily files still works after your most recent changes?

@gmao-qliu
Copy link
Contributor Author

I successfully tested the branch after my minor updates. @gmao-qliu, did you verify that the new functionality of reading from daily files still works after your most recent changes?

Yes. Verified.

@gmao-rreichle gmao-rreichle marked this pull request as ready for review February 26, 2024 15:53
@gmao-rreichle gmao-rreichle requested a review from a team as a code owner February 26, 2024 15:53
@gmao-rreichle gmao-rreichle changed the title support reading the corrected precipitation from aggregated daily netcdf files support reading corrected precipitation from aggregated daily netcdf files Feb 26, 2024
@gmao-rreichle gmao-rreichle marked this pull request as draft February 26, 2024 15:54
@gmao-rreichle gmao-rreichle marked this pull request as ready for review February 26, 2024 17:52
@gmao-rreichle gmao-rreichle merged commit 14ca604 into develop Feb 26, 2024
7 checks passed
@gmao-rreichle gmao-rreichle deleted the feature/qliu/read_precipcor_dailyfiles branch February 26, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants