Auto PR - develop → MAPL-v3 - add ascat mask to read_obs #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
1) Updates regarding MODIS obs. reader
- Added the description of MODIS obs. reader at the subroutine
(Table of longitude band is moved up)
- Changed the hdf-related function to read (vdata vs. SDS dataset)
: Previous hdf-related functions are cleaned up
- Updated and checkced the QC procedure by comparing against Matlab result
2) Updates on subroutine cat_enkf_increment
- Removing the cat_diagS at ths subroutine
:Cat_diagS is also removed when the subroutine is called (e.g., ensupd_enkf_update.F90)
- Computed the snow diagnostics to apply condition when to add/remove snow or no further action needed
: This commit has been made to update the error status located @ subroutine get_ind_obs()
: Basically, not significant change made on the code compared to the previous commit. All the print statements for debugging purposes are commented out
: Minor change made on the MODIS SCA reader(in clsm_ensupd_read_obs.F90) to correctly read the MODIS observation
: Things need to be done
1) Check the compressed vector ('Observation') lat, long, and tilenum to see whether it correctly calculates or not
2) Check the tile_grid properties
** Brief updates compared to commits made on 11/08/2021] - No more errors related to the subroutine get_ind_obs() - Checked the details of tilenum, Observation vector, and Obs_pred vector (meeting slide at 11/19/2021) - Another floating error occured when calculating the snow heat content (located within the subroutine clsm_ensupd_upd_routine.F90) code line where showed error: TSN = min(met_force(n)%Tair-MAPL_TICE,0.0) - I've tried to calculate the different between met_force%Tair -MAPL_TICE before entering the loop, and i defined it as deduction (array) and call nth deduction value in the if loop. Still, it revealed a problem. - For the review purpose, It would be great help if you can look close into the subroutine clsm_ensupd_upd_routine.F90 (from line 4076 ot 4261)
- fixed typos - fixed indentation - added/edited comments - removed redundant initialization of cat_progn_incr - removed redundant cat_progn_incr%wesn=0 etc in "do nothing" case of snow analysis - undid partial (!) deletion of an old, commented-out subroutine
…_fraction_assimilation land_assim: yes; pertubation:0; no mwRTM file
…ensup_read_obs.F90)
…as into feature/amfox/ascat_mask
…AS_ensdrv_mpi.F90, LDASsa_DEFAULT_inputs_ensupd.nml, read_obsparam.m, clsm_ensupd_read_obs.F90)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Automatic PR:
develop→release/MAPL-v3Description
add ascat mask to read_obs
📁 Modified files
.../LDAS_App/LDASsa_DEFAULT_inputs_ensupd.nml | 272 ++++-
src/Applications/LDAS_App/tile_bin2nc4.F90 | 2 +-
.../LDAS_App/util/shared/matlab/read_obsparam.m | 6 +-
.../clsm_ensupd_enkf_update.F90 | 113 ++-
.../clsm_ensupd_glob_param.F90 | 19 +-
.../clsm_ensupd_read_obs.F90 | 1055 +++++++++++++++++++-
.../clsm_ensupd_upd_routines.F90 | 367 ++++++-
.../GEOS_LandPertGridComp.F90 | 2 +
.../LDAS_Shared/LDAS_ensdrv_mpi.F90 | 4 +-
.../GEOSldas_GridComp/LDAS_Shared/enkf_types.F90 | 10 +-
10 files changed, 1685 insertions(+), 165 deletions(-)