-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASCAT mask maker input utility program #729
Conversation
src/Applications/LDAS_App/util/inputs/ASCAT_sm_mask/ascat_mask_maker.F90
Outdated
Show resolved
Hide resolved
src/Applications/LDAS_App/util/inputs/ASCAT_sm_mask/ascat_mask_maker.F90
Outdated
Show resolved
Hide resolved
src/Applications/LDAS_App/util/inputs/ASCAT_sm_mask/ascat_mask_maker.F90
Outdated
Show resolved
Hide resolved
- clarified comments and error messages - change "== 1" to "/= 0" for consistency with ASCAT EUMETSAT reader - avoid repeated allocate/deallocate within i,j loop - use nint() to avoid risky integer division when calculating N_lon, N_lat
@amfox37 : Thanks for the latest changes. I added one more commit. Please take a look and let me know if the changes are ok with you. |
… file (LDASsa_DEFAULT_inputs_ensupd.nml, ascat_mask_maker.F90)
@amfox37 : I implemented the path/filename changes in this commit. Please review, test the new functionality from scratch (new build) to make sure that ascat_mask_maker.x still works as intended, and then let me know. Once I have your confirmation, I'll go ahead and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weiyuan-jiang @gmao-rreichle My update to the CMakeLists works OK and builds but doesn't install, but I don't know if addingesma_add_subdirectories(util/inputs/ASCAT_sm_mask)
is the correct thing to do?
File removed. |
Thanks, @amfox37. I think @weiyuan-jiang gave his ok on the single CMakeLists.txt file here: "If there is no other fortran files, we dont need to add all the CMakeLists.txt" (note that the formatting in the original comment was a bit messed up). |
@mathomp4, @weiyuan-jiang: FYI, I was able to merge this GEOSldas PR without formal CMake approval. Because @weiyuan-jiang had already looked at it, I went for it and merged. |
This program reads in a NetCDF file containing ASCAT soil moisture masks available from:
Lindorfer, R., Wagner, W., Hahn, S., Kim, H., Vreugdenhil, M., Gruber, A., Fischer, M., & Trnka, M. (2023).
Global Scale Maps of Subsurface Scattering Signals Impacting ASCAT Soil Moisture Retrievals (1.0.0) [Data set].
TU Wien. https://doi.org/10.48436/9a2y9-e5z14
It provides the possibility to combine different masks (current default case is combination of subsurface and wetland masks) and interpolates onto a regular grid with a (hardwired) 0.1 degree lat/lon resolution and -90/-180 degree lower left corner used for quick indexing in the ASCAT observation reader QC routine, writing the final output to a NetCDF file.