Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASCAT mask maker input utility program #729

Merged
merged 12 commits into from
Mar 19, 2024

Conversation

amfox37
Copy link
Contributor

@amfox37 amfox37 commented Mar 12, 2024

This program reads in a NetCDF file containing ASCAT soil moisture masks available from:
Lindorfer, R., Wagner, W., Hahn, S., Kim, H., Vreugdenhil, M., Gruber, A., Fischer, M., & Trnka, M. (2023).
Global Scale Maps of Subsurface Scattering Signals Impacting ASCAT Soil Moisture Retrievals (1.0.0) [Data set].
TU Wien. https://doi.org/10.48436/9a2y9-e5z14

It provides the possibility to combine different masks (current default case is combination of subsurface and wetland masks) and interpolates onto a regular grid with a (hardwired) 0.1 degree lat/lon resolution and -90/-180 degree lower left corner used for quick indexing in the ASCAT observation reader QC routine, writing the final output to a NetCDF file.

@amfox37 amfox37 added the 0-diff label Mar 12, 2024
@amfox37 amfox37 self-assigned this Mar 12, 2024
amfox37 and others added 5 commits March 13, 2024 09:26
- clarified comments and error messages
- change "== 1" to "/= 0" for consistency with ASCAT EUMETSAT reader
- avoid repeated allocate/deallocate within i,j loop
- use nint() to avoid risky integer division when calculating N_lon, N_lat
@gmao-rreichle
Copy link
Contributor

@amfox37 : Thanks for the latest changes. I added one more commit. Please take a look and let me know if the changes are ok with you.

@gmao-rreichle
Copy link
Contributor

@amfox37 : I implemented the path/filename changes in this commit. Please review, test the new functionality from scratch (new build) to make sure that ascat_mask_maker.x still works as intended, and then let me know. Once I have your confirmation, I'll go ahead and merge.
Also, I made a copy of the Lindorfer et al file into a new sub-dir "./Mask", so please remove: /discover/nobackup/projects/gmao/smap/SMAP_Nature/ASCAT_EUMETSAT/subsurface_scattering_ASCAT_ERA5_Land.nc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weiyuan-jiang @gmao-rreichle My update to the CMakeLists works OK and builds but doesn't install, but I don't know if addingesma_add_subdirectories(util/inputs/ASCAT_sm_mask) is the correct thing to do?

@amfox37
Copy link
Contributor Author

amfox37 commented Mar 19, 2024

File removed.
Everything seems to be working as expected with a clean build - although I'm afraid I don't know if adding esma_add_subdirectories(util/inputs/ASCAT_sm_mask) is actually the correct thing to do? Or are you supposed to add a file to each subdirectory and only add one level at a time? Otherwise good to go I think

@gmao-rreichle
Copy link
Contributor

File removed. Everything seems to be working as expected with a clean build - although I'm afraid I don't know if adding esma_add_subdirectories(util/inputs/ASCAT_sm_mask) is actually the correct thing to do? Or are you supposed to add a file to each subdirectory and only add one level at a time? Otherwise good to go I think

Thanks, @amfox37. I think @weiyuan-jiang gave his ok on the single CMakeLists.txt file here: "If there is no other fortran files, we dont need to add all the CMakeLists.txt" (note that the formatting in the original comment was a bit messed up).
I will go ahead and ask for official CMake approval.

@gmao-rreichle gmao-rreichle marked this pull request as ready for review March 19, 2024 21:55
@gmao-rreichle gmao-rreichle requested review from a team as code owners March 19, 2024 21:55
@gmao-rreichle gmao-rreichle added 0-diff trivial very, very obvious 0-diff change and removed 0-diff labels Mar 19, 2024
@gmao-rreichle gmao-rreichle merged commit cea441d into develop Mar 19, 2024
9 checks passed
@gmao-rreichle gmao-rreichle deleted the feature/amfox/ascat_mask_maker branch March 19, 2024 21:58
@gmao-rreichle
Copy link
Contributor

@mathomp4, @weiyuan-jiang: FYI, I was able to merge this GEOSldas PR without formal CMake approval. Because @weiyuan-jiang had already looked at it, I went for it and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-diff trivial very, very obvious 0-diff change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants