Point to GEOSgcm_GridComp branch with non-0-diff snow model fixes #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This non-0-diff PR makes the GEOSldas
developbranch use the GEOSgcm_GridComp branchbugfix/rreichle/snow_excs, which implements the non-0-diff snow model fixes of GEOS-ESM/GEOSgcm_GridComp#813.These fixes should be used in GEOSldas going forward, and the plan for GEOSldas release
v18.0.0-betais to point to a GEOSgcm_GridComp tag (SMAP_NRv11.1) that includes the fixes.Merging this PR will require re-baselining all GEOSldas nightly tests.
Merging this PR will also require keeping the GEOSgcm_GridComp branch
bugfix/rreichle/snow_excsof GEOS-ESM/GEOSgcm_GridComp#813 synchronized with the GEOSgcm_GridCompdevelopbranch.Once the non-0-diff snow model fixes have been merged into the GEOSgcm_GridComp
developbranch, the GEOSldasdevelopbranch must be reverted back to pointing to the GEOSgcm_GridCompdevelopbranch, and GEOSldas releasev18.0.0-betamust be created that is 0-diff w.r.t.v18.0.0-beta. Note thatv18.0.0should also include the restructuring of the GEOSldas repo (tentatively #717).@mathomp4 @biljanaorescanin @weiyuan-jiang