Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to setup a GEOSldas experiment from somebody else's build #733

Merged
merged 8 commits into from
Mar 21, 2024

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Mar 18, 2024

Closes #699

This is my attempt at making ldas_setup.py usable by anyone. This (I think) should use a tempfile instead. Perhaps @biljanaorescanin can try it? Well I guess there are two tests:

  • Builder of the clone can make an experiment
  • Someone else can make an experiment using another's install dir

ETA: Note: my editor strips whitespace, so probably good to "hide whitespace" in the Files changed tab.

@mathomp4 mathomp4 self-assigned this Mar 18, 2024
@mathomp4 mathomp4 changed the title Use tempfile for domain def Use tempfile for domain def at setup Mar 18, 2024
@weiyuan-jiang
Copy link
Contributor

Thanks @mathomp4 . This is a great start. But I believe it is not enough. The fortran program will produce a temporary file "f2g.txt". I am wondering if fortran can accept it and write to it. I will try.

@mathomp4
Copy link
Member Author

Thanks @mathomp4 . This is a great start. But I believe it is not enough. The fortran program will produce a temporary file "f2g.txt". I am wondering if fortran can accept it and write to it. I will try.

Ohh. I didn't know about f2g.txt. Can the commands that need that file accept an input/output file name? Then I suppose you could make another NamedTemporaryFile, and pass that filename into the the commands that need it. Then it would all be temp files.

@gmao-rreichle
Copy link
Contributor

I was able to verify that I can setup and run an experiment using Weiyuan's build.
I also ran the nightly tests, which all passed except for the expected comparison "failure" for the new 6-h inst output in the LDAS_*GLOBAL/model tests.

@gmao-rreichle gmao-rreichle marked this pull request as ready for review March 21, 2024 00:12
@gmao-rreichle gmao-rreichle requested a review from a team as a code owner March 21, 2024 00:12
@gmao-rreichle gmao-rreichle changed the title Use tempfile for domain def at setup Allow users to setup a GEOSldas experiment from somebody else's build Mar 21, 2024
@gmao-rreichle gmao-rreichle merged commit 3a57d2c into develop Mar 21, 2024
11 checks passed
@gmao-rreichle gmao-rreichle deleted the feature/mathomp4/699-use-tempfile branch March 21, 2024 00:14
gmao-rreichle added a commit that referenced this pull request Mar 21, 2024
The present PR is a continuation of #733.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run ./ldas_setup from another user's install
3 participants