Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add landice gridcomp #18

Draft
wants to merge 17 commits into
base: develop
Choose a base branch
from
Draft

Conversation

weiyuan-jiang
Copy link
Contributor

This PR is corresponding to the GEOSldas PR to add GEOSlake_GridComp

@weiyuan-jiang weiyuan-jiang added enhancement New feature or request 0-diff labels Apr 10, 2024
/bin/mv ${{rstf}}${{ENSID}}_internal_checkpoint $tmp_file
/bin/rm -f $EXPDIR/input/restart/${{rstf}}${{ENSID}}_internal_rst
/bin/ln -rs $tmp_file $EXPDIR/input/restart/${{rstf}}${{ENSID}}_internal_rst
set rstfs = (${{MODEL}} 'landice')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weiyuan-jiang: "MODEL" here is the particular flavor of the land (Catchment) model. Now that we're integrating landice and lake, which include their own "model", I think it would be good to rename "MODEL" to "LANDMODEL" for clarity. Does this make sense?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I have changed the name

@gmao-rreichle
Copy link
Collaborator

@weiyuan-jiang: I just came across the following assumption in pre-processing: the *.til file must have all of the land tiles at the beginning. This has worked so far, but it is not a safe assumption (as noted in my comment from 2020). You are probably already aware of it in the context of the present PR, but I'm mentioning it here just in case.

! assume all land tiles are at the beginning

    ! assume all land tiles are at the beginning
          ! UNSAFE ASSUMPTION! - reichle, 2 Aug 2020
          
          if (typ/=MAPL_Land .and. typ/=MAPL_Land_ExcludeFromDomain) then   ! exit if not land
             
             if (logit) then
                write (logunit,*) 'WARNING: Encountered first non-land tile in *.til file.'
                write (logunit,*) '         Stop reading *.til file under the assumption that'
                write (logunit,*) '           land tiles are first in *.til file.'
                write (logunit,*) '         This is NOT a safe assumption beyond Icarus-NLv[x] tile spaces!!'
             end if
             
             exit ! assuming land comes first in the til file
             
          end if

@gmao-rreichle
Copy link
Collaborator

@weiyuan-jiang: I just came across the following assumption in pre-processing...

PS: The exact same code appears again a couple of hundred lines later:

! assume all land tiles are at the beginning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-diff enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants