more optimal distribution of tiles in cubed-sphere grid tile space #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmao-rreichle
added
the
performance
gmao-rreichle
changed the title
|
Nightly Tests summary: **These are in slurm ** and ntasks-per-node is 40 |
- use ldas_abort() instead of stop - clarified comments - fixed typos
gmao-rreichle
approved these changes
May 20, 2024
gmao-rreichle
requested changes
May 20, 2024
There was a problem hiding this comment.
@weiyuan-jiang: After I just approved the PR I noticed one more thing: It looks like elemental function rms_cs() isn't used. If so, we should delete it. Can you please take a quick look.
gmao-rreichle
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR addresses a situation where too many processors are requested for a cube-sphere tile space simulation. In this case, a process may end up with a domain that consists of a stripe that is only one grid cell wide, which causes the re-gridder to fail.
The PR ensures that each process has a stripe that is at least 2 grid cells wide.
The PR further improves the distribution of tiles onto processors.
IMPORTANT: The PR is not zero-diff for data assimilation in cube-sphere tile space. This is because the GLOBALCS/assim test case has never been zero-diff when the layout changed.
Tests are also non-zero-diff for the AGGGLOBALCS/model case, but 0-diff is not required/expected with layout changes when using "aggressive" compilation.