Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POSTPROC_HIST fix; change EXPDIR to absolute path #42

Merged
merged 2 commits into from
May 17, 2024

Conversation

weiyuan-jiang
Copy link
Contributor

@weiyuan-jiang weiyuan-jiang commented May 6, 2024

PR addresses issues with POSTPROC_HIST options 1 and 2, reported by @stefanocasirati and @gmao-jkolassa.
In a nutshell, POSTPROC_HIST did not finish properly. One reason may have been a confusion of relative and absolute paths after user edits of lenkf.j after ldas_setup. Another reason may be increased execution times for POSTPROC_HIST on NCCS/Discover.
cc: @biljanaorescanin

@weiyuan-jiang weiyuan-jiang requested a review from a team as a code owner May 6, 2024 14:16
Base automatically changed from feature/wjiang/rm_restart_options to develop May 6, 2024 14:34
@biljanaorescanin
Copy link
Collaborator

All tests passed.

@gmao-rreichle gmao-rreichle changed the title change EXPDIR to absolute path POSTPROC_HIST fix; change EXPDIR to absolute path May 17, 2024
@gmao-rreichle gmao-rreichle merged commit ad5ceb3 into develop May 17, 2024
13 checks passed
@gmao-rreichle gmao-rreichle deleted the fix/wjiang/abspath_forall branch May 17, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants