Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded assumption for number of NI instances in GOCART2G #220

Open
rmontuoro opened this issue Mar 31, 2023 · 1 comment
Open

Hardcoded assumption for number of NI instances in GOCART2G #220

rmontuoro opened this issue Mar 31, 2023 · 1 comment
Assignees

Comments

@rmontuoro
Copy link
Contributor

The GOCART2G grid component assumes that at least one instance of NI is present:

if ((self%NI%instances(1)%is_active) .and. (index(self%NI%instances(1)%name, 'data') == 0 )) then ! Nitrates currently only support one active instance. We check the NI gridded component because SO4MASS can be altered by NI chemistry.

This will cause runtime failures in configurations without NI.

@bena-nasa
Copy link
Contributor

@rmontuoro, thanks for bringing this up. Yes, I just opened another issue, related to this (#222). We need to be able to selectively turn off the GOCART2G components like was eminently doable in GOCART. This is one example of issues that prevent that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants