Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pcolarco/carbon chem loss upd #266

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

pcolarco
Copy link
Contributor

@pcolarco pcolarco commented Mar 4, 2024

This feature implements two changes:

  • It changes the formulation of the hydrophobic to hydrophilic conversion for carbon species, now defined by a time scale specified in the instance RC file. This is now specified by providing an e-folding time in days. This moves the time constant from outside the fortran to the run-time configurable RC file. This is not quite zero-diff with original code because of the precision of the specification, but testing shows nearly zero-diff result.

  • Also now present in the carbon instance RC files is a run-time configurable optional parameterized loss rate (e-folding time in days) per species and per mode. Default value for all is set to "-1" which means no use of this function. It has been tested separately for hydrophilic brown carbon (-1 6.0) which favorably improves OA:BC ratio for southern African biomass burning. This requires additional rescaling of BB emissions (increase scaling from 0.778->0.9 for BC and 0.778->1.25 for BR) to compensate for increased loss (in second case) and to improve simulation of BC (in first case). This requires further testing before recommending configuration changes, but as defined in default it is zero-diff.

@pcolarco pcolarco added the enhancement New feature or request label Mar 4, 2024
@pcolarco pcolarco requested a review from a team as a code owner March 4, 2024 16:55
Copy link

github-actions bot commented Mar 4, 2024

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: enhancement

1 similar comment
Copy link

github-actions bot commented Mar 4, 2024

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: enhancement

@pcolarco pcolarco added the Non 0-diff The changes in this pull request are non-zero-diff label Mar 4, 2024
@pcolarco pcolarco changed the base branch from main to develop March 4, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Non 0-diff The changes in this pull request are non-zero-diff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants