Skip to content

Commit

Permalink
pmn: minor changes to comments, no recompilation needed
Browse files Browse the repository at this point in the history
  • Loading branch information
dr0cloud committed Jan 11, 2023
1 parent 40ef616 commit 62de617
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 13 deletions.
23 changes: 13 additions & 10 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,19 +9,22 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Added

- Added subroutine `MAPL_SunGetLocalSolarHourAngle()` in `base/MAPL_sun_uc.F90`. This provides a
  convenient local solar hour angle diagnostic which will be used to detect local
  solar noon via the EXAMPLE OF USE in the subroutine header. See DESCRIPTION in code for more
  details. Provides the TRUE local solar hour angle (i.e., with equation of time included), but
  can also provide the MEAN value (without EOT) via FORCE_MLSHA=.TRUE. optional argument.
- Changed call to MAPL_SunOrbitCreate() inside MAPL_Generic.F90 to new MAPL_SunOrbitCreateFromConfig,
the latter which get the orbital parameters from the MAPL state's Config. In this way no default
orbital parameter values need appear in MAPL_Generic.F90. Rather, these default values are encap-
sulated where they belong in Sun_Mod in base/MAPL_sun_uc.F90 and are now explicitly named and
commented at the head of the module. This is a structural zero-diff change.
- Added subroutine `MAPL_SunGetLocalSolarHourAngle()` in `base/MAPL_sun_uc.F90`. This
provides a convenient local solar hour angle diagnostic which will be used to detect local
solar noon via the `EXAMPLE OF USE` in the subroutine header. See `DESCRIPTION` in code
for more details. Provides the TRUE local solar hour angle (i.e., with equation of time
included), but can also provide the MEAN value (without EOT) via `FORCE_MLSHA=.TRUE.`
optional argument.

### Changed

- Changed call to `MAPL_SunOrbitCreate()` inside `MAPL_Generic.F90` to call to new function
`MAPL_SunOrbitCreateFromConfig()`, the latter which get the orbital parameters from the MAPL
state's Config. In this way no default orbital parameter values need appear in `MAPL_Generic.F90`.
Rather, these default values are encapsulated where they belong in `Sun_Mod` in `base/MAPL_sun_uc.F90`
and are now explicitly named and commented on at the head of the module. This is a structural
zero-diff change.

### Fixed

- Added the correct values to halo corner of LatLon grid
Expand Down
6 changes: 3 additions & 3 deletions base/MAPL_sun_uc.F90
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,9 @@ module MAPL_SunMod
! Parameters of old orbital system (tabularized intercalation cycle)
! ------------------------------------------------------------------
real, parameter :: DEFAULT_ORBIT_ECCENTRICITY = 0.0167
real, parameter :: DEFAULT_ORBIT_OBLIQUITY = 23.45
real, parameter :: DEFAULT_ORBIT_PERIHELION = 102.0
integer, parameter :: DEFAULT_ORBIT_EQUINOX = 80
real, parameter :: DEFAULT_ORBIT_OBLIQUITY = 23.45 ! degrees
real, parameter :: DEFAULT_ORBIT_PERIHELION = 102.0 ! degrees
integer, parameter :: DEFAULT_ORBIT_EQUINOX = 80 ! days

! Parameters of new orbital system (analytic two-body), which allows some
! time-varying behavior, namely, linear variation in LAMBDAP, ECC, and OBQ.
Expand Down

0 comments on commit 62de617

Please sign in to comment.