Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXPID and EXPDSC are required by Cap #1080

Closed
mathomp4 opened this issue Oct 13, 2021 · 5 comments · Fixed by #1256
Closed

EXPID and EXPDSC are required by Cap #1080

mathomp4 opened this issue Oct 13, 2021 · 5 comments · Fixed by #1256
Assignees
Labels
🪲 Bug Something isn't working ❓ Question Further information is requested

Comments

@mathomp4
Copy link
Member

So this is fun. Recently I know @gmao-rreichle asked if HISTORY.rc-like files really needed EXPID: and EXPDSC: in them. And I think @bena-nasa and @weiyuan-jiang looked at History in MAPL and said, no, probably not.

But then @biljanaorescanin tried running GEOSldas with those missing and found out that Cap apparently requires them:

call ESMF_ConfigGetAttribute(cap%cf_hist, value=EXPID, Label="EXPID:", rc=status)
_VERIFY(STATUS)
call ESMF_ConfigGetAttribute(cap%cf_hist, value=EXPDSC, Label="EXPDSC:", rc=status)
_VERIFY(STATUS)
call MAPL_ConfigSetAttribute(cap%cf_hist, value=heartbeat_dt, Label="RUN_DT:", rc=status)
_VERIFY(STATUS)
call MAPL_ConfigSetAttribute(cap%cf_root, value=EXPID, Label="EXPID:", rc=status)
_VERIFY(STATUS)
call MAPL_ConfigSetAttribute(cap%cf_root, value=EXPDSC, Label="EXPDSC:", rc=status)
_VERIFY(STATUS)

It grabs them from the cap%cf_hist and puts them in cap%cf_root.

My guess is some ESMF magic could be done to make these optional a la:

call ESMF_ConfigFindLabel(cap%cf_hist, label="EXPID:", isPresent=isPresent, rc=status)
if (isPresent)
   call ESMF_ConfigGetAttribute(cap%cf_hist, value=EXPID,  Label="EXPID:",  rc=status)
end if

And then something similar when it's set in cap%cf_root?

@gmao-rreichle
Copy link

Thanks, @mathomp4. FYI, for now we're just keeping EXPDSC: and EXPSRC: in the GEOSldas HIST template, see GEOS-ESM/GEOSldas#465
If you decide to make them optional, we can remove them from the GEOSldas HIST template once GEOSldas catches up with the corresponding MAPL tag.
The challenge will be to remember to do so...

@mathomp4
Copy link
Member Author

mathomp4 commented Nov 1, 2021

@bena-nasa or @atrayano Do you know why cap%cf_root might need these? Maybe William's NUOPC work?

@stale
Copy link

stale bot commented Dec 31, 2021

This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days, it will be closed. You can add the "long term" tag to prevent the Stale bot from closing this issue.

@stale stale bot added the ❄️ Stale This issue has been marked stale label Dec 31, 2021
@gmao-rreichle
Copy link

@mathomp4, does this issue still apply to recent editions of MAPL?

@stale stale bot removed the ❄️ Stale This issue has been marked stale label Dec 31, 2021
@mathomp4
Copy link
Member Author

@gmao-rreichle I believe it still might only because I can't remember any updates changing this. Probably hasn't been top priority, but I'll bring it up with the team on Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 Bug Something isn't working ❓ Question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants