Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to MAPL v2.15.0, remove EXPDSC: and EXPSRC: from GEOSldas_HIST.rc #506

Merged
merged 2 commits into from
Jan 5, 2022

Conversation

gmao-rreichle
Copy link
Contributor

@gmao-rreichle gmao-rreichle commented Jan 3, 2022

GEOSldas_HIST.rc included EXPDSC: and EXPSRC: which were expected by MAPL but not used. See MAPL issue #1080.
MAPL pull request #1256 made these inputs optional.

This GEOSldas PR should be merged once the MAPL tag used by GEOSldas includes the above change.

UPDATE 4 Jan 2022: Added change to MAPL v2.15.0 to this PR.

cc: @mathomp4, @weiyuan-jiang, @biljanaorescanin

@mathomp4
Copy link
Member

mathomp4 commented Jan 4, 2022

@gmao-rreichle MAPL 2.15.0 is now released. This should have the fix from @weiyuan-jiang to allow you to have EXPDSC: and EXPID: as optional (I think EXPSRC: always was?)

@gmao-rreichle gmao-rreichle changed the title Remove EXPDSC: and EXPSRC: from GEOSldas_HIST.rc Update to MAPL v2.15.0, remove EXPDSC: and EXPSRC: from GEOSldas_HIST.rc Jan 4, 2022
@gmao-rreichle
Copy link
Contributor Author

Thanks, @mathomp4.
@biljanaorescanin, when you get a chance, please test this PR. If successful, please go ahead with approval and merge.

@biljanaorescanin
Copy link
Contributor

All tests passed.

@biljanaorescanin biljanaorescanin merged commit d9bb840 into develop Jan 5, 2022
@biljanaorescanin biljanaorescanin deleted the feature/rreichle/GEOSldas_HIST_rc_cleanup branch January 5, 2022 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants