Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move the four numbers to MAPL Constants? #1818

Closed
weiyuan-jiang opened this issue Nov 16, 2022 · 6 comments
Closed

move the four numbers to MAPL Constants? #1818

weiyuan-jiang opened this issue Nov 16, 2022 · 6 comments
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.

Comments

@weiyuan-jiang
Copy link
Contributor

MAPL/generic/MAPL_Generic.F90

Lines 4119 to 4133 in 8bb4b4a

call MAPL_GetResource(STATE, ECC, Label="ECCENTRICITY:", default=0.0167, &
RC=status)
_VERIFY(status)
call MAPL_GetResource(STATE, OB, Label="OBLIQUITY:", default=23.45, &
RC=status)
_VERIFY(status)
call MAPL_GetResource(STATE, PER, Label="PERIHELION:", default=102.0, &
RC=status)
_VERIFY(status)
call MAPL_GetResource(STATE, EQNX, Label="EQUINOX:", default=80, &
RC=status)
_VERIFY(status)

@weiyuan-jiang weiyuan-jiang added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Nov 16, 2022
@weiyuan-jiang weiyuan-jiang mentioned this issue Nov 16, 2022
Closed
@mathomp4
Copy link
Member

Those are @dr0cloud things, so I'm mentioning him here...

@dr0cloud
Copy link
Collaborator

Are these constants being duplicated any where else? Anyone who accesses the Orbit should now do so through the mechanisms of MAPL_SunGetInsolation which uses these constants, not through some other adhoc routine. I did notice the other day that there were orbital parameters in the MAPL Physical Constants. Who is using these?

@mathomp4
Copy link
Member

As @weiyuan-jiang points out, they are in some catch code it looks like:

GEOS-ESM/GEOSgcm_GridComp#667

@stale
Copy link

stale bot commented Jan 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days, it will be closed. You can add the "long term" tag to prevent the Stale bot from closing this issue.

@stale stale bot added the ❄️ Stale This issue has been marked stale label Jan 15, 2023
@mathomp4
Copy link
Member

@weiyuan-jiang @dr0cloud Is this now taken care of via #1920 ?

@stale stale bot removed the ❄️ Stale This issue has been marked stale label Jan 15, 2023
@dr0cloud
Copy link
Collaborator

dr0cloud commented Jan 16, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mathomp4 @dr0cloud @weiyuan-jiang