Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pFlogger uninitialized in unit tests #2290

Closed
tclune opened this issue Aug 2, 2023 · 0 comments
Closed

pFlogger uninitialized in unit tests #2290

tclune opened this issue Aug 2, 2023 · 0 comments
Assignees
@tclune
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🪲 Bug Something isn't working 📈 MAPL3 MAPL 3 Related

Comments

@tclune
Copy link
Collaborator

tclune commented Aug 2, 2023

If any tests ever were to cover code that uses pFlogger, the tests would crash. Discovered in development on generic3g.
@tclune tclune added 🪲 Bug Something isn't working 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related labels Aug 2, 2023
@tclune tclune self-assigned this Aug 2, 2023
mathomp4 added a commit that referenced this issue Aug 2, 2023
@mathomp4
Merge pull request #2291 from GEOS-ESM/feature/tclune/#2290-pflogger-…
eb1f722 
…init-unit-tests

Fixes #2290 - pflogger in unit tests
@github-actions github-actions bot mentioned this issue Aug 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tclune tclune

Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🪲 Bug Something isn't working 📈 MAPL3 MAPL 3 Related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tclune