Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1912. Fixes for ACG Cmake code #1916

Merged
merged 3 commits into from
Jan 13, 2023

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Jan 9, 2023

Description

This PR fixes #1912 where the new ACG use in DataSea (and Ocean) were exposing a bug in the mapl_acg.cmake function. We were making assumptions on the state specs filename that were incorrect.

Related Issue

closes #1912

Motivation and Context

We should be able to do make install with no changes and get nothing recompiled!

How Has This Been Tested?

Built and tested with GEOS. Zero-diff.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Jan 9, 2023
@mathomp4 mathomp4 requested a review from a team as a code owner January 9, 2023 20:22
@mathomp4 mathomp4 self-assigned this Jan 9, 2023
@mathomp4 mathomp4 linked an issue Jan 9, 2023 that may be closed by this pull request
@tclune tclune merged commit f7d7c80 into develop Jan 13, 2023
@tclune tclune deleted the feature/mathomp4/1912-fix-acg-cmake branch January 13, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACG Rebuild Issue again in GEOS: datasea (and Ocean?)
2 participants