-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create MAPL.profiler logger #1938
Conversation
@tclune Please take a look at this. It was a pretty one-for-one swap of writes to logger. But perhaps I'm now violating how logger should be used with things like logger-on-one-process: if (my_rank == 0) then
report_lines = reporter%generate_report(t_p)
lgr => logging%get_logger('MAPL.profiler')
call lgr%info('Report on process: %i0', my_rank)
do i = 1, size(report_lines)
call lgr%info('%a', report_lines(i))
end do
end if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooh nice. I had no idea that this was being worked on!
Looks good to me! Thanks for putting this together. |
Description
This PR creates a new
MAPL.profiler
logger and moves some current writes to use logger:For GEOS, this will create pretty much the same log output as long as:
is in
logging.yaml
. As such, an PR will be needed for GEOSgcm_App (see GEOS-ESM/GEOSgcm_App#391)Related Issue
Closes #1930
Motivation and Context
This will allow users to have most of MAPL at WARNING LEVEL but have the timers always output.
How Has This Been Tested?
Tested with GEOS. Zero-diff.
Types of changes
Checklist: