Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1941
This implements the bit shaving as a layout independent algorithm when used.
This is obviously non-zero diff for History diagnostic output when using the nbits option in History unless your application is only being run on a single MPI processes but also obviously has no effect on the module checkpoints and MODEL non-zero diff.
I only marked this as non-zero diff because it will change history diagnostic output. I don't know if that makes zero-diff or non-zero diff, i.e. does the non 0-diff label only apply to restarts.
note per @tclune request I also moved the code to Shared from PFIO, hence why there seems to be a lot of code changes here for a simple algorithmic change.
Also note I had to go against the official MAPL style guide and prepend the c routines in shavemantissa with MAPL_ as there is a copy of this c code in little cfio so if I did not do this, we have name collisions
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: