Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update build like UFS CI test #1950

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Update build like UFS CI test #1950

merged 1 commit into from
Feb 2, 2023

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Feb 2, 2023

Description

Updates the CI "build like UFS" test.

Related Issue

Motivation and Context

As UFS builds MAPL in a different way, we want to make sure we don't accidentally break that.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added the 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label Feb 2, 2023
@mathomp4 mathomp4 self-assigned this Feb 2, 2023
@mathomp4
Copy link
Member Author

mathomp4 commented Feb 2, 2023

Well, didn't crash. Maybe this is too strict for UFS, but it's not bad. I'll undraft

@mathomp4 mathomp4 marked this pull request as ready for review February 2, 2023 19:47
@mathomp4 mathomp4 requested a review from a team as a code owner February 2, 2023 19:47
@tclune tclune merged commit d42853e into develop Feb 2, 2023
@tclune tclune deleted the feature/mathomp4/update-build-mapl-like-ufs branch February 2, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

Assignees

@mathomp4 mathomp4

Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mathomp4 @tclune